Skip to content

Issue #2950 [LanguageNavigation v2] Accessibility and usability improvments #2951

Open
renow-luxembourg wants to merge 3 commits intoadobe:mainfrom
renow-luxembourg:renow_fix_languagenavigation_V2
Open

Issue #2950 [LanguageNavigation v2] Accessibility and usability improvments #2951
renow-luxembourg wants to merge 3 commits intoadobe:mainfrom
renow-luxembourg:renow_fix_languagenavigation_V2

Conversation

@renow-luxembourg
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #2950
Patch: Bug Fix?
Minor: New Feature? Yes
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Changes description :

  • Replace the nav container by a div and move the aria-label attribute to the ul element
  • Automatically hide the component if the website is in only 1 language
  • Display both the ISO code and the full language name. One of them can be visually hidden using some CSS similar to the "sr-only" class.
  • Add a parameter in the cq_dialog to display the language as a dropdown list using the disclosure design pattern

If it's easier, I can split this pull request into several.

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@vladbailescu
Copy link
Member

@renow-luxembourg , thank you for submitting this PR! Since the changes affect the HTML structure of the component output, they are not backwards compatible and will break existing implementations on automatic upgrades, therefore they can only be considered for a future version of the LanguageNavigation component.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LanguageNavigation v2] Remove nav element + improvement

2 participants