Skip to content

Issue #2728 [Image v3] Add a lang attribute on image#2949

Open
renow-luxembourg wants to merge 1 commit intoadobe:mainfrom
renow-luxembourg:renow_fix_img_lang
Open

Issue #2728 [Image v3] Add a lang attribute on image#2949
renow-luxembourg wants to merge 1 commit intoadobe:mainfrom
renow-luxembourg:renow_fix_img_lang

Conversation

@renow-luxembourg
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #2728
Patch: Bug Fix?
Minor: New Feature? Yes
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Steps :

  1. Get the content of ./jcr:content/metadata/dc:language from the Image DAM properties
  2. Compare this value with the current page language
  3. If value are different, add a lang attribut on the img tag

@sonarqubecloud
Copy link

@vladbailescu
Copy link
Member

@renow-luxembourg , thank you for submitting this PR! The changes need to be rebased on top of the latest component version in order to be reviewed by our team. With #2988 a new way to inject attributes was added, perhaps that could be leveraged to also add the lang attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Image v3] Add a lang attribute on image that contain text in foreign language

2 participants