You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In a recent accessibility audit, several issues were found in the carousel component :
For people using vocalization tool (NVDA, JAWS, VoiceOver, etc.), each slide content is vocalized twice due to the 2 aria-live attributes.
Controls and Indicators should come before the slides content in the tabulation order
Indicator are not initially focusable, we have to add the tabindex attribute before starting the carousel (mostly in carousel without autoplay)
On each slide there are 2 attributes that give the accessible name : aria-label and aria-labelledby, some vocalization tool read both and it's a bit annoying
When the carousel controls buttons only contain an icon, it's a nice-to-have to allow the user to display to know what this button is about using a title attribute
Carousel indicator item should be actionable using the spacebar. The easy way to do it is to use the native button element.
Q
A
Fixed Issues?
Patch: Bug Fix?
Minor: New Feature?
Yes
Major: Breaking Change?
Tests Added + Pass?
Yes
Documentation Provided
Yes (code comments and or markdown)
Any Dependency Changes?
License
Apache License, Version 2.0
Environment
AEM 6.5
Core Components version 2.28.0
Documentation
We have to implement the properties specified in the design pattern of carousel and tab :
@renow-luxembourg , thank you for submitting this PR! Since it changes the indicators element and position in the DOM structure, it's unfortunately not backwards compatible and would break existing implementations (for Cloud Service Core Components get automated upgrades). We might be able to consider this change for a future version of the Carousel component, meanwhile we recommend customers implement such modifications by overlaying in their own proxy components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nicolasambroise
force-pushed
the
renow_fix_carousel
branch
from
Feature Request
Is your feature request related to a problem? Please describe.
In a recent accessibility audit, several issues were found in the carousel component :
Environment
AEM 6.5
Core Components version 2.28.0
Documentation
We have to implement the properties specified in the design pattern of carousel and tab :