Using DPR to force the devices using the right image#2818
Open
PeterPoetsch wants to merge 2 commits intoadobe:mainfrom
Open
Using DPR to force the devices using the right image#2818PeterPoetsch wants to merge 2 commits intoadobe:mainfrom
PeterPoetsch wants to merge 2 commits intoadobe:mainfrom
Conversation
Devices with have higher then DPR 1 using different css pixel width from the source set. This leads to the problem that these devices are using the wrong image - using the one for a bigger with. This fix will solve this issue.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
=========================================
Coverage 87.17% 87.17%
Complexity 2703 2703
=========================================
Files 235 235
Lines 7210 7210
Branches 1103 1103
=========================================
Hits 6285 6285
Misses 366 366
Partials 559 559 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devices with have higher then DPR 1 using different css pixel width from the source set. This leads to the problem that these devices are using the wrong image - using the one for a bigger with. This fix will solve this issue.