[Issue #2776] Don't ever initialize a com.adobe.cq.wcm.core.components.models.Component instance to retrieve an ID#2777
Open
paulochang wants to merge 5 commits intoadobe:mainfrom
Open
[Issue #2776] Don't ever initialize a com.adobe.cq.wcm.core.components.models.Component instance to retrieve an ID#2777paulochang wants to merge 5 commits intoadobe:mainfrom
paulochang wants to merge 5 commits intoadobe:mainfrom
Conversation
HitmanInWis
reviewed
Jun 6, 2024
content/src/content/jcr_root/apps/core/wcm/components/text/v1/text/text.html
Outdated
Show resolved
Hide resolved
The testing property was mistakenly replaced on the text markup.
There was a missing placeholder in the string to be formatted on the selector variable
|
paulochang
commented
Jun 7, 2024
...ot/apps/core/wcm/components/experiencefragment/v1/experiencefragment/experiencefragment.html
Show resolved
Hide resolved
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




I have replaced all the initialization and calls to the general Component model with a call to the specific component model for each model.
Example:
Given the existing Button HTL code
I have done a replacement with the following code instead