Skip to content

Theme editor changes for core components support#1809

Merged
sakshi-arora1 merged 37 commits intodevfrom
ThemeEditorCC
Feb 10, 2026
Merged

Theme editor changes for core components support#1809
sakshi-arora1 merged 37 commits intodevfrom
ThemeEditorCC

Conversation

@muskgupta
Copy link
Member

Description

These changes focus on adding support for applying theme editor to core components based forms.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Copy link
Contributor

@sakshi-arora1 sakshi-arora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change copyright year to 2026

Copy link
Contributor

@sakshi-arora1 sakshi-arora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style config needs to updated in main readme for component addition / creation / modification

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../components/internal/constants/ThemeConstants.java 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

if (StringUtils.isBlank(themeContentPath)) {
if (request != null) {
themeContentPath = request.getParameter(ThemeConstants.THEME_OVERRIDE); // embed component use-case
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

77-79 remove

</sly>
<sly data-sly-use.clientlib="core/wcm/components/commons/v1/templates/clientlib.html"
data-sly-use.formstructparser="com.adobe.cq.forms.core.components.models.form.FormStructureParser">
<sly data-sly-test.clientLibRef="${formstructparser.clientLibRefFromFormContainer}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the use case of clientLibRefFromFormContainer?

@sakshi-arora1 sakshi-arora1 merged commit 554315d into dev Feb 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants