Skip to content

feat: enhance tabs to support additional fields - #15

Merged
buuhuu merged 70 commits into
mainfrom
tabs
Aug 26, 2025
Merged

feat: enhance tabs to support additional fields#15
buuhuu merged 70 commits into
mainfrom
tabs

Conversation

@bhellema

Copy link
Copy Markdown
  • tabs support title, heading(Type), image, and richtext
  • bring script.js and editor-support*.js files up to date from aem-boilerplate-xwalk

flx-sta and others added 30 commits January 26, 2024 11:48
the `<select>` element does not support the `value` attribute thus the `option.value` needs to be compared to the `fd.Value` instead of ~~`select.value`~~
update mountpoint
update mount-point
fix: js doc comment with correct return type
Support Cell alignment in Table Block
chore: remove renovate, update deps to match aem-boilerplate
fix(a11y): add aria-label for links to achieve 100 a11y scores
chore: adding cleanup-on-create.yaml  as in aem-boilerplate
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate Bot and others added 7 commits July 19, 2025 00:15
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…e#107)

* chore(deps): update dependency stylelint-config-standard to v39

* chore: linting

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: kptdobe <acapt@adobe.com>
- tabs support title, heading(Type), image, and richtext
@aem-code-sync

aem-code-sync Bot commented Aug 22, 2025

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

- do not force default, as importing sites with no content will get default content which is not expected
@buuhuu
buuhuu changed the base branch from main to update-from-upstream August 25, 2025 12:04
Comment thread blocks/tabs/_tabs.json
"component": "text",
"valueType": "string",
"name": "heading",
"name": "content_heading",

@bhellema bhellema Aug 25, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This becomes very messy for our AI to describe how to generate the table. Can't these just be separate cells, it's easy for the AI then to say place this into cell 1, place image into cell 2, place the content into cell 3.

Let me noodle on this today and see if I can get AI to generate this kind of table.

@buuhuu
buuhuu changed the base branch from update-from-upstream to main August 26, 2025 07:16
@buuhuu
buuhuu merged commit 1af0c2a into main Aug 26, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants