Skip to content

Reduce buffer size when writing partial ids#2857

Open
RobinTF wants to merge 1 commit intoad-freiburg:masterfrom
RobinTF:smaller-buffer
Open

Reduce buffer size when writing partial ids#2857
RobinTF wants to merge 1 commit intoad-freiburg:masterfrom
RobinTF:smaller-buffer

Conversation

@RobinTF
Copy link
Copy Markdown
Collaborator

@RobinTF RobinTF commented May 4, 2026

This PR reduces the arbitrary buffer size of 1GB used to buffer IO writes for ids when parsing with an equally arbitrary 8MB buffer, which shows no difference in performance in small scale testing, but reduces the memory footprint by almost a whole GB.

@sparql-conformance
Copy link
Copy Markdown

Overview

Number of Tests Passed ✅ Intended ✅ Failed ❌ Not tested
548 447 73 28 0

Conformance check passed ✅

No test result changes.

Details: https://qlever.dev/sparql-conformance-ui?cur=a6e59f886d75f0250103d6807383c7dc8afdaff8&prev=f54b0a34f8d91af3bbdb7dbc32f115d295e11c31

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (04f32a1) to head (a6e59f8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2857   +/-   ##
=======================================
  Coverage   92.37%   92.38%           
=======================================
  Files         510      510           
  Lines       44109    44118    +9     
  Branches     5834     5833    -1     
=======================================
+ Hits        40746    40758   +12     
+ Misses       1702     1701    -1     
+ Partials     1661     1659    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant