Reduce buffer size when writing partial ids#2857
Open
RobinTF wants to merge 1 commit intoad-freiburg:masterfrom
Open
Reduce buffer size when writing partial ids#2857RobinTF wants to merge 1 commit intoad-freiburg:masterfrom
RobinTF wants to merge 1 commit intoad-freiburg:masterfrom
Conversation
Overview
Conformance check passed ✅No test result changes. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2857 +/- ##
=======================================
Coverage 92.37% 92.38%
=======================================
Files 510 510
Lines 44109 44118 +9
Branches 5834 5833 -1
=======================================
+ Hits 40746 40758 +12
+ Misses 1702 1701 -1
+ Partials 1661 1659 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR reduces the arbitrary buffer size of 1GB used to buffer IO writes for ids when parsing with an equally arbitrary 8MB buffer, which shows no difference in performance in small scale testing, but reduces the memory footprint by almost a whole GB.