Simplify partial vocab phase and reduce memory#2856
Open
RobinTF wants to merge 7 commits intoad-freiburg:masterfrom
Open
Simplify partial vocab phase and reduce memory#2856RobinTF wants to merge 7 commits intoad-freiburg:masterfrom
RobinTF wants to merge 7 commits intoad-freiburg:masterfrom
Conversation
RobinTF
changed the title
Overview
Conformance check passed ✅No test result changes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2856 +/- ##
==========================================
- Coverage 92.37% 92.37% -0.01%
==========================================
Files 510 510
Lines 44109 44089 -20
Branches 5834 5832 -2
==========================================
- Hits 40746 40727 -19
- Misses 1702 1706 +4
+ Partials 1661 1656 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the partial vocab phase by avoiding computing sort keys (that consume a lot of memory) and simply comparing the strings with each other on the fly when sorting.
The helper type
TripleComponentOrId(alias ofstd::variant<PossiblyExternalizedIriOrLiteral, Id>) is replaced withPossiblyExternalizedTripleComponentbecause the wrappedTripleComponentcan already store plainIds, so the variant is not necessary, which also helps reducing the memory footprint.Finally
LocalVocabIndexAndSplitValis renamed toPartialVocabIndexWithExternalFlagand shrunken down to a single 64 bit int which is sufficient to store the partial vocab index and a external bool, which reduces the memory footprint even further since the bool would be padded with 7 extra bytes otherwise.Small scale testing showed a minimal increase (~1%) in performance with this change applied.