Sister permutation sharing to reduce redundant triple storage#2783
Open
joka921 wants to merge 3 commits intoad-freiburg:masterfrom
Open
Sister permutation sharing to reduce redundant triple storage#2783joka921 wants to merge 3 commits intoad-freiburg:masterfrom
joka921 wants to merge 3 commits intoad-freiburg:masterfrom
Conversation
When building permutation pairs (SPO↔SOP, PSO↔POS, OSP↔OPS), blocks of small relations in the second writer (writer2) now reference the corresponding block in the first writer (writer1) instead of storing their own compressed data. At read time, the shared block is read from the sister permutation, columns are swapped, and the result is resorted. This reduces index size by avoiding duplicate compressed storage for blocks that contain the same triples in a different column order. Key changes: - Add BlockSharingInfo struct and sharingInfo_ field to block metadata - Writer2 creates shared block references via addSharedBlockMetadata - Reader handles shared blocks via readSharedBlock (swap + resort) - Permutation objects track sister/cross-pair links for reader access - Buffer-to-block index mapping enables fix-up after block sorting - PSO↔POS sister links are always set up (not just when all perms loaded) - Cross-pair sharing infrastructure is in place but disabled (TODO) - Index format version bumped to reflect metadata format change Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
…ion sharing. The CrossPairPermutation enum value is retained in BlockSharingInfo for serialization compatibility, but guarded with AD_CORRECTNESS_CHECK(false) so it is never used at read time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Overview
Conformance check failed ❌Test Status Changes 📊
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CrossPairPermutationenum value is retained inBlockSharingInfofor serialization format compatibility, but guarded withAD_CORRECTNESS_CHECK(false)so it is never used at read time.Test plan
CompressedRelationsTestpasses (22 tests)IndexTestpasses (17 tests)🤖 Generated with Claude Code