Merged
Conversation
winfredLIN
reviewed
Jan 17, 2025
iwanghc
force-pushed
the
add_audit_result_error_result_ce
branch
from
cf58bb1 to
4e5bfc9
Compare
winfredLIN
approved these changes
Jan 17, 2025
| newAr := &AuditResult{ | ||
| Level: string(dar.Level), | ||
| RuleName: dar.RuleName, | ||
| ExecutionFailed: dar.ExecutionFailed, |
Collaborator
There was a problem hiding this comment.
遗留到之后处理，这种变量命名失去了原有对象的含义
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联的 issue
#2860
描述你的变更
新增audit_execution_error类型表示审核规则执行报错
审核规则执行报错将错误信息记录到audit result中，防止报错的审核规则被跳过无感知
确认项（pr提交后操作）
Tip
请在指定复审人之前，确认并完成以下事项，完成后✅
not_compatibleneed_update_doc