Conversation
Styles and UI details are not finished yet. Theme needs to be finetuned
Added `Table` theme definition, added vaults related constants.
Remove max width and set correct padding according to the figma views.
improve responsiveness.
Closes: ACR-19 This PR removes the additional rewards component.
Depends on: #948 Closes: ACR-18 This PR updates the main page layout according to the Figma designs.
Extracted rendered values to variables, reverted `getPercentValue` changes.
Used `logPromiseFailure` wrapper function
The only allowed child nodes of `<tfoot />` are `<tr />`s.
Rewards Earned & Estimated APR
Starknet to tBTC
Closes ACR-21 ### Changes - Implemented `Vaults` component with (mocked) data fetching - Added `formatNumberToCompactString` utility function - Refactored `getPercentageValue` utility function - Added `VAULT_PROVIDERS` and `VAULT_CURATORS` constants - Added `StarknetIcon` component - Added theme for `Table` components > [!note] > > Query function is mocked. It's artificially delayed and randomly throws error. ### Screenshots - Loaded <img src="https://github.com/user-attachments/assets/31b22c0b-3031-4135-b6c4-6fece6572c36" /> - Loading <img src="https://github.com/user-attachments/assets/d873bb13-d03f-4925-a1d0-2a4c82c5a31b" /> - Error <img src="https://github.com/user-attachments/assets/a20463a1-4758-4c94-bd8c-95eb5d85d324" />
Added initial data and fixed missed errors
Ref ACR-21 Closes ARC-21 ### Changes - Removed mocked Vaults API call - Add APR _(est.)_ label - Removed chevron icon - Reduced font size (16 to 14) <img width="2118" height="526" alt="image" src="https://github.com/user-attachments/assets/68a89c2c-6c4a-46cd-9e6c-a2a805e9d83e" />
Instead of hardcoded addresses.
Update unit tests of `initializeWithdrawal` function from `account` module.
Add `redeemerOutputScript` to the `Withdraw`. We need to save the `redeemerOutputScript` to request async withdrawal via bot. The contract only stores `redeemerOutputScriptHash` so we are unable to build the tBTC redemption data and request a redemption via tBTC v2 sdk.
This reverts commit 99660f4.
Add `amountToRedeem` field to save the tBTC amount that will be used during the tBTC redemption process.
In the previous implementation, we passed the parameter `redeemerOutputScript` incorrectly. It was not prepended with its length, which caused the tBTC redemption process for this withdrawal could not be executed. The `redeemerOutputScript` must be a length-prefixed output script. To ensure the correct format, we now build the data using the tBTC v2 SDK, which provides the proper format.
Add unit tests for `buildRedemptionData` w/o mocking the tBTC v2 sdk or ethers signer, to verify the redemption data is built correctly with real tBTC v2 SDK implementation.
Update unit tests of account module.
Adjust the implementation to the new version of the subgraph.
Add the new `status` - `requested`. The withdrawal can have `requested` status.
We can handle this by `status` field. There is no need to add additional type of the activity.
Add `select` param so we can pass this function to the `useQquery` hook. Here we also handle the new statuses of the withdrawal flow and set correct data for the activity object.
Display only the activities for which the status is different from `requested`. Only withdrawals can have this status and we want to display them in a separate place.
Closes: ACR-58 This PR adds support for registering the `acreBTC` token in the Ledger Live Desktop app. If the user has ever made a Bitcoin deposit in Acre the dapp calls the Ledge Live method to register the `acreBTC` token in the Ledger Live Desktop app. After this action, the user should be able to see their account in the portfolio. <img width="1216" height="171" alt="obraz" src="https://github.com/user-attachments/assets/d4844af0-bd5f-407a-afb1-65aa1a73b142" />
Add docs for the `Withdrawal` type.
Update copy: - `Est. time remaining` -> `Est. duration`.
Closes: ACR-78 This PR aligns the SDK and dapp with the new withdrawal flow.
Closes: ACR-77 Depends on: #971 This PR updates the subgraph to handle the new withdrawal flow. I deployed and published subgraph on mainnet and testnet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.