Skip to content

Fix TN9710P probe on MV88X3310 boards#82

Open
Skyline-23 wants to merge 1 commit intoacooks:release/linux-6.7.y-1from
Skyline-23:fix/tn9710p-mv88x3310-probe
Open

Fix TN9710P probe on MV88X3310 boards#82
Skyline-23 wants to merge 1 commit intoacooks:release/linux-6.7.y-1from
Skyline-23:fix/tn9710p-mv88x3310-probe

Conversation

@Skyline-23
Copy link
Copy Markdown

Summary

  • treat a zero PHY ID as the actual no-PHY signal so MV88X3310 boards on MDIO port 0 can probe
  • reset the PHY on the scanned MDIO port instead of hardcoding port 1
  • pass the DMA address directly to dma_free_coherent() to avoid the probe-time crash seen on Ubuntu 24.04 / kernel 6.8

Validation

  • reproduced on a Tehuti TN9710P card (1fc9:4027, subsystem 1fc9:3015)
  • before this change, the driver failed with PHY init failed
  • with the MDIO fix plus the MV88X3310 firmware blob present, the driver detects the PHY and creates enp3s0
  • before the DMA fix, probe then crashed in bdx_tx_free(); after the fix, the crash no longer reproduces

Notes

  • the MV88X3310 firmware blob is still required for this board, but is not included here

- treat a zero PHY ID as the actual no-PHY signal so MDIO port 0 remains valid\n- reset the PHY on the scanned MDIO port instead of hardcoding port 1\n- pass the DMA address directly to dma_free_coherent to avoid the probe-time crash on newer kernels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant