fix(concerto-vocabulary): look up terms by own property only#1276
Open
apoorva-01 wants to merge 1 commit into
Open
fix(concerto-vocabulary): look up terms by own property only#1276apoorva-01 wants to merge 1 commit into
apoorva-01 wants to merge 1 commit into
Conversation
getTerm/getElementTerms matched with `propertyName in d`, which walks the prototype, so names like hasOwnProperty or constructor returned a built-in Function. Match own properties via Object.prototype.hasOwnProperty.call. Signed-off-by: Apoorva Verma <vermaapoorva0510@gmail.com>
e1db2e3 to
88e3fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1241
Vocabulary.getTermandgetElementTermsmatched a property's term withpropertyName in d, which walks the prototype chain. A property named after anObject.prototypemember (hasOwnProperty,constructor,toString,valueOf) matched every declaration object and returned a built-inFunctioninstead of the term, or aFunctioninstead ofnullfor an undeclared name.Changes
Object.prototype.hasOwnProperty.call(d, propertyName), so a term comes back only for a property actually declared on the object.test/vocabulary.jscoverconstructor/toString/hasOwnPropertyresolving to their own terms and undeclared prototype names returningnull; they fail on revert. Suite (95), lint and coverage green.Flags
hasOwnProperty.callrather thanObject.hasOwn, which reads cleaner but isn't in the package'ses2020TS lib.getElementTermsalongsidegetTermsince it has the identical defect, happy to narrow togetTerm.Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname