Conversation
WalkthroughThe README and in-repo documentation were updated to demonstrate obtaining a channel with explicit options enabling object publish/subscribe modes, calling Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev
participant Realtime
participant Channel
participant LiveObjects
Dev->>Realtime: channels.get("myChannel", options: [.objectPublish, .objectSubscribe])
Realtime-->>Channel: Channel (unattached)
Dev->>Channel: attach() (await)
Channel-->>Dev: attached
Dev->>Channel: access channel.objects
Channel-->>LiveObjects: provide objects API
Dev->>LiveObjects: objects.root.get("someObject")
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
README.md (1)
28-31: Specifying LiveObjects channel modes looks right; minor doc caveatUsing
ARTRealtimeChannelOptions.modes = [.objectPublish, .objectSubscribe]and passing them on the firstgetis correct. Note: in Ably, options are only applied when the channel is first created; subsequentget("myChannel", options: ...)calls won’t update an existing channel’s modes. Consider adding a short note so readers don’t try to retrofit modes on an already-instantiated channel.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
|
I need to address the feedback re waiting for attach to complete (I am deliberately not because it's really ugly; see ably/ably-cocoa#2087) and also copy this documentation to the docstring for the plugin |
Specify channel modes, and attach the channel (we will shortly be introducing an implicit attach on getRoot but we don't have it yet).
2a344c8 to
89e63d4
Compare
|
Merging this — tests are flaky (will be investigating soon) but there are no code changes here |
Specify channel modes, and attach the channel (we will shortly be introducing an implicit attach on
getRootbut we don't have it yet).Summary by CodeRabbit