Skip to content

Always transition to SYNCING on receipt of ATTACHED#104

Merged
lawrence-forooghian merged 1 commit intomainfrom
80-always-transition-to-SYNCING-on-ATTACHED
Dec 8, 2025
Merged

Always transition to SYNCING on receipt of ATTACHED#104
lawrence-forooghian merged 1 commit intomainfrom
80-always-transition-to-SYNCING-on-ATTACHED

Conversation

@lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented Dec 5, 2025

Note: This PR is based on top of #103; please review that one first.

This copies the change added in the referenced JS commit (from ably/ably-js#2121).

@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 80-always-transition-to-SYNCING-on-ATTACHED

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot temporarily deployed to staging/pull/104/AblyLiveObjects December 5, 2025 14:51 Inactive
This copies the change added in the referenced JS commit.
@lawrence-forooghian lawrence-forooghian force-pushed the 80-always-transition-to-SYNCING-on-ATTACHED branch from 8e1dba6 to 1c901a8 Compare December 5, 2025 17:55
Base automatically changed from 80-reconcile-redundant-sync-state to main December 8, 2025 12:00
@lawrence-forooghian lawrence-forooghian merged commit 6c84d76 into main Dec 8, 2025
18 checks passed
@lawrence-forooghian lawrence-forooghian deleted the 80-always-transition-to-SYNCING-on-ATTACHED branch December 8, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants