fix(smtp): try to authenticate with the UPN from OAuth#256
Open
lucaasmth wants to merge 1 commit intoabhinavxd:mainfrom
Open
fix(smtp): try to authenticate with the UPN from OAuth#256lucaasmth wants to merge 1 commit intoabhinavxd:mainfrom
lucaasmth wants to merge 1 commit intoabhinavxd:mainfrom
Conversation
- Add function to extract the UPN from the OAuth access token - Use this UPN to authenticate to the SMTP server, fallback to the username
Owner
|
hey thanks for the PR! This needs to be also done for imap I believe not just SMTP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the handling of OAuth authentication for Microsoft SMTP by ensuring the XOAUTH2 username matches the User Principal Name (UPN) in the JWT access token, which is required for successful authentication. The changes introduce a helper function to extract the UPN from the token and update the authentication logic accordingly.
In my case I had two different emails on the Microsoft account and I couldn't authenticate to the SMTP server with the first, which is the one present in the email field of the JWT access token.
Changes
extractUPNFromTokenininternal/inbox/channel/email/smtp.goto extract the UPN (or fallback tounique_name) from a JWT access token, ensuring proper username selection for Microsoft SMTP.NewSmtpPoolfunction to use the extracted UPN as the XOAUTH2 username if available, otherwise defaulting to the configured username, improving compatibility with Microsoft SMTP requirements.