feat(adt-contracts): Add RAP contracts with BDEF, DDLS, and Generator support#93
feat(adt-contracts): Add RAP contracts with BDEF, DDLS, and Generator support#93kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Conversation
… support - Add behaviourDefinitionsContract for /sap/bc/adt/rap/behaviours endpoint - Add ddlsContract for /sap/bc/adt/ddl/ddls endpoint - Add rapGeneratorContract for /sap/bc/adt/rap/generator endpoint - Export rapContract from adt/index.ts - Add contract definition tests in tests/adt/rap.test.ts - Integration tests check for ADT_SERVICE_KEY availability
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
The PR adds RAP (RESTful ABAP Programming) contracts with:
Code follows existing patterns, uses the Reviewed by minimax-m2.5-20260211 · 204,870 tokens |
|
View your CI Pipeline Execution ↗ for commit 62b0aab
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ The fix from Nx Cloud was applied
We removed ../adt-client and ../adt-auth from the references array in packages/adt-contracts/tsconfig.json to fix the circular TypeScript project reference that was causing the adt-contracts:build failure. Since adt-client already references adt-contracts, adding the reverse reference created a cycle that prevented rolldown-plugin-dts from loading the package entry points. None of the new RAP contract files import from adt-client or adt-auth, so these references were both incorrect and unnecessary.
Tip
✅ We verified this fix by re-running adt-contracts:build.
Suggested Fix changes
diff --git a/packages/adt-contracts/tsconfig.json b/packages/adt-contracts/tsconfig.json
index 04a5e92..3247407 100644
--- a/packages/adt-contracts/tsconfig.json
+++ b/packages/adt-contracts/tsconfig.json
@@ -10,12 +10,6 @@
},
"include": ["src/**/*.ts", "tests/**/*.ts"],
"references": [
- {
- "path": "../adt-client"
- },
- {
- "path": "../adt-auth"
- },
{
"path": "../adt-schemas"
},
➡️ This fix was applied by Petr Plenkov
🎓 Learn more about Self-Healing CI on nx.dev
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: kilo-code-bot[bot] <kilo-code-bot[bot]@users.noreply.github.com>
|
Summary
/sap/bc/adt/rap/behaviours/sap/bc/adt/ddl/ddls/sap/bc/adt/rap/generatorFiles
packages/adt-contracts/src/adt/rap/behaviours.ts- BDEF contractpackages/adt-contracts/src/adt/rap/ddls.ts- DDLS contractpackages/adt-contracts/src/adt/rap/generator.ts- RAP Generator contractpackages/adt-contracts/src/adt/rap/index.ts- Module exportspackages/adt-contracts/tests/adt/rap.test.ts- Tests