Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the "Junkie" and "Memberberry" themes and introduces several popular color schemes, including Dracula, Solarized (Dark and Light), Gruvbox, Nord, Monokai, One Dark, Tokyo Night, and Synthwave '84. The changes update the localization files, the settings store, and the theme utility definitions. Feedback was provided regarding the Solarized Light theme, specifically noting that the button text colors have insufficient contrast against the background, which may impact accessibility.
| buttonBackground: '#B58900', | ||
| buttonGradient: ['#B58900', '#CB4B16'], | ||
| buttonText: '#FDF6E3', | ||
| buttonTextSecondary: '#93A1A1', |
There was a problem hiding this comment.
The buttonText and buttonTextSecondary colors in the SolarizedLight theme have insufficient contrast against the buttonBackground (#B58900, a yellow/orange color). Using a light color like #FDF6E3 (Base3) for text on a yellow background results in a low contrast ratio, which can impact readability and accessibility. Consider using a darker color from the Solarized palette, such as #002B36 (Base03) or #586E75 (Base01), for better visibility.
| buttonBackground: '#B58900', | |
| buttonGradient: ['#B58900', '#CB4B16'], | |
| buttonText: '#FDF6E3', | |
| buttonTextSecondary: '#93A1A1', | |
| buttonBackground: '#B58900', | |
| buttonGradient: ['#B58900', '#CB4B16'], | |
| buttonText: '#002B36', | |
| buttonTextSecondary: '#586E75', |
Description
Relates to issue: ZEUS-0000
Please enter a description and screenshots, if appropriate, of the work covered in this PR
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
On-device
Remote
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: