Skip to content

ui: new themes#3947

Draft
kaloudis wants to merge 1 commit intoZeusLN:masterfrom
kaloudis:ui-new-themes
Draft

ui: new themes#3947
kaloudis wants to merge 1 commit intoZeusLN:masterfrom
kaloudis:ui-new-themes

Conversation

@kaloudis
Copy link
Copy Markdown
Contributor

@kaloudis kaloudis commented Apr 5, 2026

Description

Relates to issue: ZEUS-0000

Please enter a description and screenshots, if appropriate, of the work covered in this PR

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

On-device

  • LDK Node
  • Embedded LND

Remote

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the "Junkie" and "Memberberry" themes and introduces several popular color schemes, including Dracula, Solarized (Dark and Light), Gruvbox, Nord, Monokai, One Dark, Tokyo Night, and Synthwave '84. The changes update the localization files, the settings store, and the theme utility definitions. Feedback was provided regarding the Solarized Light theme, specifically noting that the button text colors have insufficient contrast against the background, which may impact accessibility.

Comment on lines +454 to +457
buttonBackground: '#B58900',
buttonGradient: ['#B58900', '#CB4B16'],
buttonText: '#FDF6E3',
buttonTextSecondary: '#93A1A1',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The buttonText and buttonTextSecondary colors in the SolarizedLight theme have insufficient contrast against the buttonBackground (#B58900, a yellow/orange color). Using a light color like #FDF6E3 (Base3) for text on a yellow background results in a low contrast ratio, which can impact readability and accessibility. Consider using a darker color from the Solarized palette, such as #002B36 (Base03) or #586E75 (Base01), for better visibility.

Suggested change
buttonBackground: '#B58900',
buttonGradient: ['#B58900', '#CB4B16'],
buttonText: '#FDF6E3',
buttonTextSecondary: '#93A1A1',
buttonBackground: '#B58900',
buttonGradient: ['#B58900', '#CB4B16'],
buttonText: '#002B36',
buttonTextSecondary: '#586E75',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant