fix: remove duplicate swap fee fetch on startup

[a-khushal]

Description

Relates to issue: ZEUS-3911

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

On-device

• Embedded LND
• LDK Node

Remote

• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (CLNRest)
• Nostr Wallet Connect
• LndHub

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[gemini-code-assist]

Code Review

This pull request removes the call to SwapStore.getSwapFees() within the Wallet component's connection logic, specifically when node information is being fetched. There are no review comments to evaluate, and I have no feedback to provide.

[ajaysehwal]

https://github.com/a-khushal/zeus/blob/360e23986870b2b9a6ce6e186b3f2f173d2fc2fa/stores/SwapStore.ts#L54

@a-khushal, I think we should add { fireImmediately: true } to the getHost → getSwapFees reaction so the first fee load still runs when getHost doesn’t change after connect.

[myxmaster]

There is a regression in Send.tsx and PaymentRequest.tsx: both views consume SwapStore.reverseInfo/subInfo to decide whether to show the swap icon in header, but neither fetches up-to-date fees/data themselves. Since startup no longer preloads data from swap provider, we would not see the swap icon, although amount is inside the min/max limits for a swap (isAmountValidToSwap returns false silently because the store data is empty).

My commit myxmaster@a0f742a (cherry-pick if you want) fixes this by:

• Send.tsx: triggering getSwapFees() in componentDidUpdate when transactionType resolves to 'On-chain' (lazy, only when a swap is actually relevant), and moving the isAmountValidToSwap check out of local state into render() directly so MobX reactivity kicks in when swap fees/data arrive
• PaymentRequest.tsx: same approach, getSwapFees() fire-and-forget in componentDidMount, and isAmountValidToSwap() evaluated in render() (not in the nested SwapButton sub-component, where MobX tracking wouldn't apply) so the button appears automatically once fees load

[a-khushal]

There is a regression in Send.tsx and PaymentRequest.tsx: both views consume SwapStore.reverseInfo/subInfo to decide whether to show the swap icon in header, but neither fetches up-to-date fees/data themselves. Since startup no longer preloads data from swap provider, we would not see the swap icon, although amount is inside the min/max limits for a swap (isAmountValidToSwap returns false silently because the store data is empty).

My commit myxmaster@a0f742a (cherry-pick if you want) fixes this by:

• Send.tsx: triggering getSwapFees() in componentDidUpdate when transactionType resolves to 'On-chain' (lazy, only when a swap is actually relevant), and moving the isAmountValidToSwap check out of local state into render() directly so MobX reactivity kicks in when swap fees/data arrive
• PaymentRequest.tsx: same approach, getSwapFees() fire-and-forget in componentDidMount, and isAmountValidToSwap() evaluated in render() (not in the nested SwapButton sub-component, where MobX tracking wouldn't apply) so the button appears automatically once fees load

I cherry-picked your fix (a0f742a) into this branch.

[myxmaster]

Ah, we should also handle the empty initial state of reverseInfo/subInfo in isAmountValidToSwap in both Send.tsx:

if (!reverseInfo || Object.keys(reverseInfo).length === 0) {

and PaymentRequest.tsx:

if (!subInfo || Object.keys(subInfo).length === 0) {

Otherwise the swap icon is shortly displayed before fees are loaded.

Besides that:
tACK