Updates for NadHat#2
Open
sdoubey wants to merge 9 commits into
Open
Conversation
Fix Configurator properties misspelling
Update configurator to look into modem folder for configuration Add SIMCOM SIM800C configuration (NadHAT)
Add support for CMSGSText response with +CDS (+160 chars messages) Fix inbound message date parse error
Owner
|
Great job sir. I do some tests and merge as soon as possible. The NadHat card look very interesting. Thanks for the contribution :) |
Replace jssc with pi4j for serial communication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of these updates is to support NadHat card
I had to add "SIMCOM_Ltd_SIMCOM_SIM800C" configuration and update configurator to load properties file from classpath OR modem folder
I had to fix date parsing for incoming SMS because i got this error,
java.time.format.DateTimeParseException: Text '18/08/11,22:36:21+0000' could not be parsed, unparsed text found at index 20, so i had to changeyy/MM/dd,HH:mm:ssxtoyy/MM/dd,HH:mm:ssX, to support both formatsI had to handle response for SMS larger than 160 characters, when i tried i got this response from
CMGSTextcommand:[+CDS: 6,178,"+33XXXXXXX",145,"18/08/12,00:54:21+08","18/08/12,00:54:21+08",0<R><N><R><N><R><N>+CMGS: 179<R><N><R><N>]but you are waiting for something like that:
[<R><N>+CMGS: 181<R><N><R><N>OK<R><N>]so i changed
matcher.matchestomatcher.find, it's more permissive and does the job