Skip to content

Add Scorn support#123

Open
revanmj wants to merge 5 commits intoZ1ni:mainfrom
revanmj:patch-6
Open

Add Scorn support#123
revanmj wants to merge 5 commits intoZ1ni:mainfrom
revanmj:patch-6

Conversation

@revanmj
Copy link
Copy Markdown
Contributor

@revanmj revanmj commented Feb 7, 2024

No description provided.

@Z1ni
Copy link
Copy Markdown
Owner

Z1ni commented Jul 2, 2024

Thanks for the PR!

I'm liking the separate Scorn handling instead of adding the is_scorn argument to the 1c1f handler, as it's not really generic and reusable whereas the suffix argument is.

So if you can remove the b0a04d0 and 591005b commits (interactive rebase) and maybe also remove the unnecessary suffix argument from the scorn handler, I'll merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants