Skip to content

Improve PIV Certificate names #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdmoreira merged 1 commit into from
Mar 2, 2026
Merged

Improve PIV Certificate names #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Authenticator/UI/Helpers/SecCertificate+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ extension SecCertificate: Equatable {
SecCertificateCopyCommonName(self, &name)
return name as String?
}

var subjectSummary: String? {
SecCertificateCopySubjectSummary(self) as String?
}

func tokenObjectId() -> String {
let data = SecCertificateCopyData(self) as Data
Expand Down
4 changes: 2 additions & 2 deletions Authenticator/UI/YubiKeyConfiguration/SmartCardConfigurationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ class SmartCardConfigurationController: UITableViewController {
} else {
let cell = tableView.dequeueReusableCell(withIdentifier: "CertificateCell", for: indexPath) as! CertificateCell
let certificate = certificates[indexPath.row - 1]
cell.name = "\(certificate.certificate.commonName ?? String(localized: "No name", comment: "PIV extension certificate with no name")) (slot \(String(format: "%02X", certificate.slot.rawValue)))"
cell.name = "\(certificate.certificate.subjectSummary ?? String(localized: "No name", comment: "PIV extension certificate with no name")) (slot \(String(format: "%02X", certificate.slot.rawValue)))"
if !tokens.contains(certificate.certificate) {
cell.action = { [weak self] in
self?.storeTokenCertificate(certificate: certificate.certificate)
Expand All @@ -236,7 +236,7 @@ class SmartCardConfigurationController: UITableViewController {
} else {
let cell = tableView.dequeueReusableCell(withIdentifier: "CertificateCell", for: indexPath) as! CertificateCell
let token = tokens[indexPath.row - 1]
cell.name = token.commonName
cell.name = token.subjectSummary
cell.setSymbol(symbol: "minus.circle")
cell.action = { [weak self] in
self?.removeTokenCertificate(certificate: token)
Expand Down
Loading