[AIE2PS] Mark all aie2ps intrinsics as having default attributes#944
Open
konstantinschwarz wants to merge 1 commit intoaie-publicfrom
Open
[AIE2PS] Mark all aie2ps intrinsics as having default attributes#944konstantinschwarz wants to merge 1 commit intoaie-publicfrom
konstantinschwarz wants to merge 1 commit intoaie-publicfrom
Conversation
konstantinschwarz
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
Without these, LLVM needs to be conservative for some intrinsics and assume they never return. Adding the default attributes enables more optimizations, similar to what was done for AIE2p.
konstantinschwarz
force-pushed
the
kschwarz.aie2ps.intrinsics.defaultattrs
branch
from
e0a0282 to
bcc32e6
Compare
Collaborator
|
How does the QoR look like? |
Collaborator
Author
|
Mostly flat. This was specifically targeting MX6 kernels, for which this is pretty effective (~6% improvement). 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these, LLVM needs to be conservative for some intrinsics and assume they never return. Adding the default attributes enables more optimizations, similar to what was done for AIE2p.