[AIEX][NFC] clarify MinTripCount==1 overload#861
Open
F-Stuckmann wants to merge 1 commit intoaie-publicfrom
Open
[AIEX][NFC] clarify MinTripCount==1 overload#861F-Stuckmann wants to merge 1 commit intoaie-publicfrom
F-Stuckmann wants to merge 1 commit intoaie-publicfrom
Conversation
F-Stuckmann
requested review from
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
F-Stuckmann
force-pushed
the
stuckmann.hardware.loops.tripcount
branch
from
00a18d9 to
47bfa91
Compare
konstantinschwarz
requested changes
Mar 20, 2026
Collaborator
konstantinschwarz
left a comment
konstantinschwarz
left a comment
There was a problem hiding this comment.
I agree with this change.
However, we used the Min Tripcount == 1 as a poor hack to disable hardware loop generation. This was necessary to control code bloat in very size constrained loops.
We should have a separate pragma to disable hardware loops. Until then, we should not merge this change. Setting to Request changes to avoid accidentally merging this PR
F-Stuckmann
force-pushed
the
stuckmann.hardware.loops.tripcount
branch
from
47bfa91 to
a67ae54
Compare
Collaborator
Author
|
I changed the PR to only add a comment explaining our |
| cl::desc("Enable true zero overhead hardware loops on AIE"), | ||
| cl::init(true), cl::Hidden); | ||
|
|
||
| /// We currently override MinIterCountHLReject == 1 to |
F-Stuckmann
changed the title
konstantinschwarz
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow HW loops when MinTripCount ==1.