Draft
Conversation
F-Stuckmann
changed the title
| StringRef FuncUnitWrapper::SlotLetters; | ||
| void FuncUnitWrapper::setFormatInterface(const AIEBaseMCFormats *Formats) { | ||
| FormatInterface = Formats; | ||
| SlotLetters = Formats ? Formats->getSlotLetters() : StringRef(); |
Collaborator
There was a problem hiding this comment.
This is a performance penalty on every single scheduling action to cache something only necessary for dumping.
| } | ||
|
|
||
| /// Initialize the format interface and derive slot letter abbreviations | ||
| /// from it. Must be called before slot-aware debug output is used. |
Collaborator
There was a problem hiding this comment.
Oh, this has always been an eyesore. We may be able to arrange for this in AIEBaseSubtarget. FormatInterface is a AIE-wide extension to InstrInfo. / ItineraryData
| } | ||
| dbgs() << "\t"; | ||
| Cycle.dump(); | ||
| dbgs() << (C == 0 ? ">" : " ") << format("%3d", C) << ":\t"; |
Collaborator
There was a problem hiding this comment.
Tip: format("%c%3d:\t", C==0 ? '>' : ' ', C)
Add getSlotLetters() virtual to AIEBaseMCFormats with per-architecture slot-to-letter mappings. Use these letters in FuncUnitWrapper::dump() and PostPipeliner debug functions instead of numeric digits.
Add optional II parameter to ResourceScoreboard::dumpFull(). When provided, a blank line is inserted after every II-th cycle to visually separate modulo stages.
Track which schedule lengths have been dumped to avoid duplicate output. Dump intervals the first time each unique length is encountered in the heuristic and relaxed strategy loops.
Add LLVM_DEBUG output when checkConflict() rejects a modulo cycle in fitInInterval, making it easier to diagnose why an instruction could not be placed at a particular cycle.
F-Stuckmann
force-pushed
the
stuckmann.postpipeliner.debug
branch
from
ebbd732 to
9a7dcaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain each declined scheduling decision in the postpipeliner.
This is a draft, I am still not happy with some parts of it.