PR for MoveLinearPastEltwiseMul transformation#1275
Open
shashwat1198 wants to merge 2 commits intoXilinx:devfrom
Open
PR for MoveLinearPastEltwiseMul transformation#1275shashwat1198 wants to merge 2 commits intoXilinx:devfrom
shashwat1198 wants to merge 2 commits intoXilinx:devfrom
Conversation
Signed-off-by: shashwat1198 <shashwatsep98@gmail.com>
Collaborator
|
We already have this in FINN+ as the "MoveConstMulPastJoinMul" transformation. Christoph (@iksnagreb) added it as part of the StreamlinePlus PR (eki-project#39), which doesn't yet have an equivalent in this repository I believe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR introduces a new transformation,
MoveLinearPastEltwiseMul, which optimises the computation graph by moving linear multiplication operations past elementwise multiplication operations when possible.Pattern before transformation:
[(x × A) × (y × B)]
Pattern after transformation:
[(x × y) × (A × B)]
Where (x) and (y) are dynamic inputs, and (A) and (B) are constant tensors.
Key Changes: