Update the class-directories-check.php

[carolinan]

Closes #403
Replaces #414

Fixes a bug where disallowed directories were not detected because only the filename was checked, not the full path.
Adds __MACOSX to the list of directories.
Updates the error message.

Does not detect empty folders, it seems unlikely that empty folders would be included.
It is kind of backwards to check for files and then check what folder they are in... But we already have the list of files.
This is only one way to solve this, but it is the smallest change. I don't feel strongly for or against this versus a directory scan.

Testing Instructions

You need at least two themes installed.

1. In one of the themes, add a new folder with the name __MACOSX and add a file inside it (hello.txt or whatever). (Or install a theme that has been actually zipped on a Mac: I don't have a Mac, so I cheated)
2. Run the theme check on the theme with the folder, and confirm that the correct error message shows.
3. Run the theme check on the theme without the folder and confirm that the error message does not show.

Try some of the other folder names as well.

AI Usage: I argued back and forward with Copilot.

[Copilot]

Pull request overview

Updates the Theme Check “Directories” check to correctly detect disallowed directories by inspecting full file paths (not just basenames), and adds __MACOSX to the disallowed directory list to help catch macOS ZIP artifacts.

Changes:

• Detect disallowed directories by checking path segments across full file paths.
• Add __MACOSX to the excluded/disallowed directories list.
• Update the required-message text shown when an excluded directory is found.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.