Title Check: Avoid Deprecated warnings when there's no file contents.

[dd32]

Not 100% sure how this is happening, but seems like a quick win to avoid unnecessary processing and break early.

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in wp-content/plugins/theme-check/checks/class-title-check.php on line 57 

[kafleg]

Looks good to me.

[carolinan]

I believe this closes #476 ?
I installed Astra version 4.12.4 and was able to reproduce the problem.

The PR did not solve the whole problem, I am seeing:
Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in
\theme-check\checks\class-title-check.php on line 59
That is after the preg_replace on line 55.

[carolinan]

Copilot changed it to is_string, there is now a check also after the preg_match.

Testing instructions:

1. Install the theme Astra from the .org theme directory.
2. Run theme check against Astra, confirm that there is no PHP "Deprecated" warnings.
3. In Astra, functions.php, add: wp_title();
4. Run theme check against Astra, confirm that there is a recommendation to remove wp_title.
   RECOMMENDED: wp_title() was found in the file functions.php
   This is to confirm that the check still works.

[carolinan]

There is an alternative PR that adds the is_string check to the if statement: https://github.com/WordPress/theme-check/pull/477/changes

[carolinan]

Note that with the SVG title being fixed in dfbfafd Astra cannot be used to test this anymore, the PHP warning has already been fixed. We should still fix this, we will need another theme to test on.