feat: Set (shorten) animation duration for wishlist move actions#166
Merged
Wingysam merged 3 commits intoWingysam:masterfrom Dec 31, 2025
Merged
feat: Set (shorten) animation duration for wishlist move actions#166Wingysam merged 3 commits intoWingysam:masterfrom
Wingysam merged 3 commits intoWingysam:masterfrom
Conversation
Owner
|
I think something like this should just have a forced default with no configuration. Let's make it a constant in the js like |
JadElClemens
force-pushed
the
tune_animation_duration
branch
from
2276b70 to
762e537
Compare
Contributor
Author
|
@Wingysam Rebased and updated to use a const, this is ready for review now |
Wingysam
changed the title
Wingysam
changed the title
Contributor
|
@JadElClemens - can you resolve the conflicts so that this can be merged? |
JadElClemens
force-pushed
the
tune_animation_duration
branch
from
762e537 to
ae43731
Compare
Contributor
Author
JadElClemens
force-pushed
the
tune_animation_duration
branch
from
ae43731 to
8e108eb
Compare
JadElClemens
force-pushed
the
tune_animation_duration
branch
from
1b4496b to
81d6647
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick PoC for shortening the animation duration of moving wishlist items.
Frankly, I think the default duration for
zoomInandzoomOutare downright silly. I found this 0.45s value to be reasonable through testing - I personally prefer more like0.33sbut I figured that may be a little fast for some.Would be ideal if this can be tuned in config or through environment (pending config page impl) - any ideas?