Skip to content

Remove deprecated webkitImageSmoothingEnabled#10

Open
jackfranklin wants to merge 1 commit intoWildhoney:masterfrom
jackfranklin:master
Open

Remove deprecated webkitImageSmoothingEnabled#10
jackfranklin wants to merge 1 commit intoWildhoney:masterfrom
jackfranklin:master

Conversation

@jackfranklin
Copy link
Copy Markdown

screen shot 2015-12-07 at 15 09 24

I kept getting that warning in the console, so I figured I'd remove the offending line.

Thank you for all your work on an awesome module :)

@Wildhoney
Copy link
Copy Markdown
Owner

@jackfranklin Thanks!

I found it annoying as well, but it seems we need it for Safari.

Maybe we could do a small Chrome detection to set webkitImageSmoothingEnabled using navigator.userAgent.toLowerCase().indexOf('chrome'), that way:

  • If it is Chrome, we can remove the webkit prefixed property, fixing the irritating message;
  • If it isn't Chrome, it'll always add the prefixed property;
  • If it's Chrome but UA is different, we'll simply get the current behaviour;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants