rebar3: also accept new macro format for version 3.26#148
Closed
alanz wants to merge 1 commit intoWhatsApp:mainfrom
Closed
rebar3: also accept new macro format for version 3.26#148alanz wants to merge 1 commit intoWhatsApp:mainfrom
alanz wants to merge 1 commit intoWhatsApp:mainfrom
Conversation
Contributor
alanz
added a commit
to alanz/erlang-language-platform
that referenced
this pull request
Jan 12, 2026
Summary:
`rebar3` version `3.26.0` changed the way the configured macros are stored in the manifest file.
Old format (rebar3 < 3.26.0): `[#{key => 'TEST', value => <<"true">>}]`
New format (rebar3 >= 3.26.0): `#{'TEST' => <<"true">>}`
Update the manifest loading to support both formats.
Differential Revision: D90500460
alanz
force-pushed
the
export-D90500460
branch
from
97f6955 to
dff12d3
Compare
alanz
added a commit
to alanz/erlang-language-platform
that referenced
this pull request
Jan 12, 2026
Summary:
`rebar3` version `3.26.0` changed the way the configured macros are stored in the manifest file.
Old format (rebar3 < 3.26.0): `[#{key => 'TEST', value => <<"true">>}]`
New format (rebar3 >= 3.26.0): `#{'TEST' => <<"true">>}`
Update the manifest loading to support both formats.
Differential Revision: D90500460
alanz
force-pushed
the
export-D90500460
branch
from
dff12d3 to
66e8a8c
Compare
alanz
added a commit
to alanz/erlang-language-platform
that referenced
this pull request
Jan 12, 2026
Summary:
`rebar3` version `3.26.0` changed the way the configured macros are stored in the manifest file.
Old format (rebar3 < 3.26.0): `[#{key => 'TEST', value => <<"true">>}]`
New format (rebar3 >= 3.26.0): `#{'TEST' => <<"true">>}`
Update the manifest loading to support both formats.
Differential Revision: D90500460
alanz
force-pushed
the
export-D90500460
branch
from
66e8a8c to
58133bb
Compare
Contributor
|
I am still a bit confused about this. Wasn't the manifest fix by @eproxus explicitly addressing the mismatch, moving away from a list of maps to a single map? And now we're patching ELP to support the "single map" format, because it only supports the list of maps? That doesn't make sense. |
alanz
added a commit
to alanz/erlang-language-platform
that referenced
this pull request
Jan 12, 2026
Summary:
`rebar3` version `3.26.0` changed the way the configured macros are stored in the manifest file.
Old format (rebar3 < 3.26.0): `[#{key => 'TEST', value => <<"true">>}]`
New format (rebar3 >= 3.26.0): `#{'TEST' => <<"true">>}`
Update the manifest loading to support both formats.
Differential Revision: D90500460
alanz
force-pushed
the
export-D90500460
branch
from
58133bb to
90ca465
Compare
Summary:
`rebar3` version `3.26.0` changed the way the configured macros are stored in the manifest file.
Old format (rebar3 < 3.26.0): `[#{key => 'TEST', value => <<"true">>}]`
New format (rebar3 >= 3.26.0): `#{'TEST' => <<"true">>}`
Update the manifest loading to support both formats.
Reviewed By: robertoaloi
Differential Revision: D90500460
alanz
force-pushed
the
export-D90500460
branch
from
90ca465 to
c1ebc37
Compare
Contributor
|
This pull request has been merged in 42663dd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
rebar3version3.26.0changed the way the configured macros are stored in the manifest file.Old format (rebar3 < 3.26.0):
[#{key => 'TEST', value => <<"true">>}]New format (rebar3 >= 3.26.0):
#{'TEST' => <<"true">>}Update the manifest loading to support both formats.
Differential Revision: D90500460