Skip to content

Fix lint config file not effective#142

Open
wiserfz wants to merge 1 commit intoWhatsApp:mainfrom
wiserfz:fix/lint-config
Open

Fix lint config file not effective#142
wiserfz wants to merge 1 commit intoWhatsApp:mainfrom
wiserfz:fix/lint-config

Conversation

@wiserfz
Copy link
Copy Markdown

@wiserfz wiserfz commented Dec 16, 2025

Closes #105 and #87.

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Dec 16, 2025

Hi @wiserfz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the cla signed label Dec 16, 2025
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Dec 16, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@robertoaloi
Copy link
Copy Markdown
Contributor

Hi @wiserfz and thanks for your contribution. Unfortunately, this is a bit more complicated since it would break our internal setup. I am working on an internal fix, so that we can then align the IDE and CI configurations.

@wiserfz
Copy link
Copy Markdown
Author

wiserfz commented Dec 18, 2025

Hi @wiserfz and thanks for your contribution. Unfortunately, this is a bit more complicated since it would break our internal setup. I am working on an internal fix, so that we can then align the IDE and CI configurations.

emmm, sounds very complicated, so what should I do with this PR, close it?

@robertoaloi
Copy link
Copy Markdown
Contributor

Hi @wiserfz and thanks for your contribution. Unfortunately, this is a bit more complicated since it would break our internal setup. I am working on an internal fix, so that we can then align the IDE and CI configurations.

emmm, sounds very complicated, so what should I do with this PR, close it?

Keep it open for now, no action needed from your side. I will refer to this PR once I have a fix ready.

@wiserfz
Copy link
Copy Markdown
Author

wiserfz commented Dec 20, 2025

Hi @wiserfz and thanks for your contribution. Unfortunately, this is a bit more complicated since it would break our internal setup. I am working on an internal fix, so that we can then align the IDE and CI configurations.

emmm, sounds very complicated, so what should I do with this PR, close it?

Keep it open for now, no action needed from your side. I will refer to this PR once I have a fix ready.

Ok, thank you for this language server and hope this PR will be merge soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ELP language server seems to ignore .elp_lints.toml (when in IDE)

2 participants