Skip to content

feat: improve VotingPanel accessibility with semantic attributes #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WeixuanZ wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: improve VotingPanel accessibility with semantic attributes #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2025-10-26 - Importance of Semantic Toggle States
**Learning:** Large interactive elements (like player cards in voting) often act as toggle buttons but are implemented as generic buttons. Adding `aria-pressed` instantly makes the "selected" state accessible to screen readers without needing complex radio group structures.
**Action:** When implementing "select one" or "toggle" interfaces, always verify if `aria-pressed` is needed to communicate the active state.
3 changes: 3 additions & 0 deletions frontend/src/components/game/VotingPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ export function VotingPanel({
{alivePlayers.map((player: Player) => (
<button
key={player.id}
type="button"
aria-pressed={selectedTarget === player.id}
aria-label={`Select ${player.nickname}`}
onClick={() => setSelectedTarget(player.id)}
style={{
display: 'flex',
Expand Down