fix: agent config not picked up from parameters#397
Merged
Conversation
When agent URLs where only provided through parameters (from env variables), the "dt" field was not set, which caused keripy to ignore the configuration. This PR ensure that "dt" field is set.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
=======================================
Coverage 87.75% 87.76%
=======================================
Files 26 26
Lines 5825 5826 +1
=======================================
+ Hits 5112 5113 +1
Misses 713 713 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
iFergal
approved these changes
Nov 3, 2025
kentbull
reviewed
Nov 13, 2025
kentbull
approved these changes
Feb 12, 2026
kentbull
left a comment
kentbull
left a comment
Collaborator
There was a problem hiding this comment.
KRAM dictates timestamps should be checked in order to protect
There is a security concern with adding a datetime
Collaborator
|
@lenkan please rebase. |
kentbull
approved these changes
Mar 12, 2026
Collaborator
|
@lenkan approved, please rebase and we'll pull it in. |
kentbull
approved these changes
May 26, 2026
Collaborator
|
@lenkan will you rebase this? |
iFergal
added a commit
to cardano-foundation/keria
that referenced
this pull request
Jul 17, 2026
…conflicts) (#27) * adds MAINTAINERS.md Signed-off-by: Kevin Griffin <griffin.kev@gmail.com> * adds MAINTAINERS.md Signed-off-by: Kevin Griffin <griffin.kev@gmail.com> * add hab name, prefix to logs; fix GracefulShutdownDoer to use KeyboardInterrupt instead of Doist.exit() (WebOfTrust#363) * feat: add hab name and prefix partial to log messages * feat: add TruncatedFormatter for logs; refactor GracefulShutdownDoer The TruncatedFormatter gives human readability with visual "rivers" and the GracefulShutdownDoer properly throws a KeyboardInterrupt to cause the main Doist loop to exit." * fix: use full, not abbreviated AID in logs * feat,docs: correct the graceful shutdown logic This uses the DoDoer logic properly to check shutdown conditions on each loop and then act appropriately on receiving the shutdown signal. * docs: add in documentation for various components * chore: remove extra label from log messages * chore: bump version to 0.2.0 for release to PyPi and Docker HUb * chore: add ruff linting (WebOfTrust#385) * chore: add ruff linting (WebOfTrust#385) * fix: KERIA server exits (exit code 1) on admit call with 'NoneType' object has no attribute 'ked' (WebOfTrust#379) * is:issue KERIA server exits (exit code 1) on admit call with 'NoneType' object has no attribute 'ked' WebOfTrust#371 * remove checking grant and change parser for all of enpoints in ipex --------- Co-authored-by: iFergal <fergaloconnor1998@gmail.com> * credentialing.py type hints and auto-generated OpenAPI specs (WebOfTrust#373) * spike: Feasibility of generating Signify types from Python type hints via OpenAPI * Revert "spike: Feasibility of generating Signify types from Python type hints via OpenAPI" This reverts commit 4901f19. * split Operation then using allOf in openapi schemas * demo generated types for credentials().get() * fix some option properties and add schema for CredentialState * Add custom class for empty dict schema * fix credentials types + add registries's types * Add remaining schemas for credentialing * resolve review comments * fix errors/warning for swagger validator * resolve review comments * resolve review comments * Remove unused import * fix lints and tests * integrate mypy check and fix type errors for credentialing.py * remove some unuse schemas * resolve review comment + add utils for auto generate dataclass/schema from FieldDom * support dip, drt for anc * fix lints issue * refactor openapi utils * support dip, drt for anc: fix dataclass * refactor: move logging and http concerns to modules Moved both console logging and HTTP request logging to the logs and httping modules to clean up the agenting module and keep concerns separate. Adds basic HTTP request logging configurable by log level. * feat: respect temp arg and allow cf to be passed in This allows for consistent testability where all configuration files and LMDB databases will or will not be created in tempfiles. Being able to pass a cf in means this can be more easily tested from an end-to-end integration test, which is my goal here. * feat: make Agency configuration more testable Externalize the Configer instance so that both the Agency and all Agent instances can be configured in a test prior to Agency startup. * fix: SignifyPy compatibility for CredentialCollectionEnd For some reason SignifyTS uses the 'ri' field to identify a registry and SignifyPy uses the 'ii' field to identify a registry. They should both use the 'rd' field in the future. * fix: correct indentation for getAgency find function * docs: Add ParserDoer.recur documentation * feat: upgrade to KERI 1.2.7 and new HIO * refactor: simplify Grant debugging with gathering GrantDoer GrantDoer collects all dependent KEL and TEL event artifacts for an ACDC into a single list making it easier to debug a transmission. * refactor: rename, use vars, remove indirection * refactor: move logging to monitoring package * refactor: disable request logging by default, add --logrequests option * refactor: move grant cue processor into recur * refactor: simplify middleware * add ruff format check * run ruff format * add docker step to ci * downgrade lmdb * aiding.py type hints and auto-generated OpenAPI specs (WebOfTrust#391) * spike: Feasibility of generating Signify types from Python type hints via OpenAPI * Revert "spike: Feasibility of generating Signify types from Python type hints via OpenAPI" This reverts commit 4901f19. * split Operation then using allOf in openapi schemas * demo generated types for credentials().get() * fix some option properties and add schema for CredentialState * Add custom class for empty dict schema * fix credentials types + add registries's types * Add remaining schemas for credentialing * resolve review comments * fix errors/warning for swagger validator * resolve review comments * resolve review comments * Remove unused import * fix lints and tests * integrate mypy check and fix type errors for credentialing.py * remove some unuse schemas * resolve review comment + add utils for auto generate dataclass/schema from FieldDom * support dip, drt for anc * fix lints issue * refactor openapi utils * support dip, drt for anc: fix dataclass * aiding.py type hints and auto-generated OpenAPI specs * Add data schema for GroupMemberCollectionEnd * resolve review comments * fix review comments * change type for "nt", "kt" * do not handle required/optional field for dataclass from FieldDom * fix lint error * fix cover tests * update specing test * update and use new openapi utils * update kt, nt field: allow string or array of strings or array of array of strings * update openapi spec * fix lints * resolve review comments * resolve conflicts, fix lints and update spec test * Migrate from setuptools to uv depdendency management * pin uv version to avoid breaking in the future * simplify config * fix python install * fix: renaming identifier can overwrite other identifiers with same name WebOfTrust#322 (WebOfTrust#392) * agenting.py type hints and OpenAPI specs (WebOfTrust#393) * spike: Feasibility of generating Signify types from Python type hints via OpenAPI * Revert "spike: Feasibility of generating Signify types from Python type hints via OpenAPI" This reverts commit 4901f19. * split Operation then using allOf in openapi schemas * demo generated types for credentials().get() * fix some option properties and add schema for CredentialState * Add custom class for empty dict schema * fix credentials types + add registries's types * Add remaining schemas for credentialing * resolve review comments * fix errors/warning for swagger validator * resolve review comments * resolve review comments * Remove unused import * fix lints and tests * integrate mypy check and fix type errors for credentialing.py * remove some unuse schemas * resolve review comment + add utils for auto generate dataclass/schema from FieldDom * support dip, drt for anc * fix lints issue * refactor openapi utils * support dip, drt for anc: fix dataclass * aiding.py type hints and auto-generated OpenAPI specs * Add data schema for GroupMemberCollectionEnd * resolve review comments * fix review comments * change type for "nt", "kt" * do not handle required/optional field for dataclass from FieldDom * fix lint error * fix cover tests * update specing test * update and use new openapi utils * update kt, nt field: allow string or array of strings or array of array of strings * update openapi spec * fix lints * resolve review comments * resolve conflicts, fix lints and update spec test * aiding.py type hints and auto-generated OpenAPI specs * resolve review comments * agenting.py type hints and OpenAPI specs WebOfTrust#377 * add response schema for OperationCollectionEnd * rebase/resolve conflicts from parent branch * merge parent branch * remote Receipt msg/ Routed msg in KeyEventRecord dataclass * fix: GET /credentials/{said} throws 500 for escrowed credentials WebOfTrust#400 (WebOfTrust#402) * Adding type hints for other End files delegating.py, grouping.py, ipexing.py, notifying.py, exchanging.py (WebOfTrust#399) * Adding type hints for other End files delegating.py, grouping.py, ipexing.py, notifying.py, exchanging.py * fix multisig types * continue to fix Multisig types * ci(gha): upgrade macos runner to macos-15 (WebOfTrust#407) * chore: upgrade macos runner * rename CI step for macos-15 --------- Co-authored-by: Patrick Vu <patrick.vu@sotatek.com> * feat: index outbound exchange messages (WebOfTrust#401) * fix kt, nt for KeyStateRecord type * fix: propagate log level argument to keripy logger (WebOfTrust#410) * enable keri logs * cover new test for __init__.py code * remove unnecessary tests * fix: split HabState in 2 types to account for optional attributes (WebOfTrust#411) * change transferable, windexes and state to be optional * splitting Indentifier object for list method and get method * fix spec * fix duplicate HabState * use HabState schema name instead of Identifier * revert comments for HabStateBase * fix: extra fields for getRequest should be optional in exnmultisig (WebOfTrust#417) * change transferable, windexes and state to be optional * Specify OP types * resove review comments: add missing code for KeyStateRecord kt,nt * add missing commit: fix: extra fields for getRequest should be optional in exnmultisig * upgrade to keri 1.2.12 and bump keria version to 0.4.0 Signed-off-by: Kent Bull <kent@kentbull.com> * fix flaky OpenAPI Spec test * chore: fix generation of ACDC ordering and extra fields * fix CredentialState schema * fix: ancatc type * refactor: remove print * refactor: formatting * fix: correct registry state dataclass for openapi spec * refactor: remove unused import * fix: better specify keyevents and fix group member ends * format * Fixes to sig-fix command * Fixed formatting on change * chore: upgrade to KERIpy 1.2.13 Signed-off-by: Kent Bull <kent@kentbull.com> * add changelog Signed-off-by: Kent Bull <kent@kentbull.com> * add older version docs in changelog Signed-off-by: Kent Bull <kent@kentbull.com> * add new endpoint for getting locschemes by EID * docs: fix documentation badge * chore: fix depends type in some operation metadata (WebOfTrust#441) * fix depends type in some operation metadata * remove SubmitOperation in KelOperation --------- Co-authored-by: iFergal <fergaloconnor1998@gmail.com> * normalize bool literal schema * chore: make depends required for RegistryOperationMetadata * fix: agent config not picked up from parameters (WebOfTrust#397) When agent URLs where only provided through parameters (from env variables), the "dt" field was not set, which caused keripy to ignore the configuration. This PR ensure that "dt" field is set. * chore: update multisig embeds typing to include delegated events * chore: format * chore: format * resolve review comments * revert some headers for test auth --------- Signed-off-by: Kevin Griffin <griffin.kev@gmail.com> Signed-off-by: Kent Bull <kent@kentbull.com> Co-authored-by: Kevin Griffin <griffin.kev@gmail.com> Co-authored-by: Kent Bull <kent@kentbull.com> Co-authored-by: Daniel Lenksjö <5889538+lenkan@users.noreply.github.com> Co-authored-by: iFergal <fergaloconnor1998@gmail.com> Co-authored-by: Charles Lanahan <charles.lanahan@gmail.com> Co-authored-by: Jay-Alexander Elliot <alexander.elliot.it@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When agent URLs where only provided through parameters (from env variables), the "dt" field was not set, which caused keripy to ignore the configuration. This PR ensure that "dt" field is set.