Add ImportResolver interface and use it for global imports#8166
Merged
stevenfontanella merged 14 commits intomainfrom Jan 7, 2026
Merged
Add ImportResolver interface and use it for global imports#8166stevenfontanella merged 14 commits intomainfrom
stevenfontanella merged 14 commits intomainfrom
Conversation
84c1ad0 to
75d06c7
Compare
e40fac1 to
e1e16b8
Compare
e1e16b8 to
ae1b333
Compare
tlively
reviewed
Jan 2, 2026
tlively
reviewed
Jan 2, 2026
kripken
reviewed
Jan 5, 2026
kripken
reviewed
Jan 5, 2026
tlively
reviewed
Jan 6, 2026
Comment on lines
+3420
to
+3422
| ModuleUtils::iterDefinedGlobals( | ||
| wasm, [&definedGlobalCount](auto&& _) { ++definedGlobalCount; }); | ||
| definedGlobals.reserve(definedGlobalCount); |
Member
There was a problem hiding this comment.
It would also be fine to over-reserve wasm->globals.size() slots.
Member
Author
There was a problem hiding this comment.
Good point. I guess there's no harm in leaving it this way?
kripken
reviewed
Jan 6, 2026
kripken
reviewed
Jan 6, 2026
kripken
reviewed
Jan 6, 2026
kripken
reviewed
Jan 7, 2026
kripken
reviewed
Jan 7, 2026
tlively
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an ImportResolver interface with some implementations to handle the spec interpreter and ctor-eval