fix(utils): eliminate Node.js Buffer dependencies for browser compatibility (#7176)#7196
Open
Sigmabrogz wants to merge 1 commit intoWalletConnect:v2.0from
Open
fix(utils): eliminate Node.js Buffer dependencies for browser compatibility (#7176)#7196Sigmabrogz wants to merge 1 commit intoWalletConnect:v2.0from
Sigmabrogz wants to merge 1 commit intoWalletConnect:v2.0from
Conversation
Contributor
|
All contributors have signed the CTA ✍️ ✅ |
…bility (WalletConnect#7176) Signed-off-by: Sigmabrogz <bnb1000bnb@gmail.com>
Sigmabrogz
force-pushed
the
fix/remove-buffer-7176
branch
from
3f9b227 to
6b938d3
Compare
Author
|
I have read the CTA Document and I hereby sign the CTA |
Author
|
recheck |
Author
|
Hi team, the PR is ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eliminates the usage of the Node.js
Bufferobject frompackages/utils/src(specifically incacao.ts,misc.ts,crypto.ts,polkadot.ts, andsignatures.ts). This is critical for browser usage, asBuffercauses breaking issues (Buffer is not defined) in environments where it is not polyfilled (such as the Verify API context in issue #7176).The
Bufferconversions have been replaced by the robustuint8arrayslibrary (fromString,toString,concat), ensuring full browser compatibility while keeping encoding/decoding behavior consistent.