This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Draft
Conversation
znorcross211
reviewed
May 7, 2021
znorcross211
suggested changes
May 17, 2021
znorcross211
left a comment
znorcross211
left a comment
There was a problem hiding this comment.
Overall great job! The concepts you worked on here will hopefully help you venturing into the wider CMX org.
Comment on lines
+23
to
+28
| parseIt.mockImplementation(() => { | ||
| return { | ||
| getDate: getDateMock, | ||
| getAllDates: getAllDatesMock.mockReturnValue(dateFixtures) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Not sure if we discussed this but this could get extracted using the method described at the top of the docs here. Not vital for this but it is often used.
https://jestjs.io/docs/manual-mocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft with analysis.