This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Completed core functionality (ZACHARY NORCROSS)#4
Open
znorcross211 wants to merge 3 commits intointern-practicefrom
Open
Completed core functionality (ZACHARY NORCROSS)#4znorcross211 wants to merge 3 commits intointern-practicefrom
znorcross211 wants to merge 3 commits intointern-practicefrom
Conversation
pcdroidski
reviewed
May 30, 2019
| const app = express(); | ||
|
|
||
| //TODO: Add an express router | ||
| const router = express.Router(); |
pcdroidski
reviewed
May 30, 2019
| // Setup middleware so we can read the requests body | ||
| app.use(express.json()); | ||
| app.use(express.urlencoded({ extended: true })); | ||
| app.use("/", router); // so router can work |
Contributor
There was a problem hiding this comment.
Move this router into a new file?
pcdroidski
suggested changes
May 30, 2019
|
|
||
| // TASK 1 | ||
| router.get("/mealtimes", (req, res) => { | ||
| if (req.query.query == undefined) { |
Contributor
There was a problem hiding this comment.
if (req.query.query) is better.
But Preferred:
const { query } = req.query;
| if (req.query.query == undefined) { | ||
| // if no query is given in the url | ||
| resultingJSON = { status: "success", data: [] }; | ||
| resultingJSON.data = Dates; |
Contributor
There was a problem hiding this comment.
Try to use immutability!
| if (req.query.query == undefined) { | ||
| // if no query is given in the url | ||
| resultingJSON = { status: "success", data: [] }; | ||
| resultingJSON.data = stopWordList; |
| if (isStopWord(inputString)) { | ||
| // if we have a stop word | ||
| data.type = "stopword"; | ||
| var word = getStopWord(inputString); |
Contributor
There was a problem hiding this comment.
Try not to use var -> use const
|
|
||
| function isDateWord(inputString) { | ||
| for (var i = 0; i < Dates.length; i++) { | ||
| if (Dates[i].names.includes(inputString.toLowerCase())) { |
Contributor
There was a problem hiding this comment.
Is there a way to simplify this?
| const isStopWord = (word) => { | ||
| const isStopWord = word => { | ||
| //TODO Fill this in | ||
| if (stopWordList.includes(word.toLowerCase())) { |
Contributor
|
Looks good!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.