VIDSOL-632: Add German language support and translations#412
Merged
VIDSOL-632: Add German language support and translations#412
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds German (de) to the frontend i18n system so the app can be run/displayed in German, aligning with the existing env-driven language support pattern.
Changes:
- Added
deto the supported language lists (build env + frontend env parsing/types). - Registered German resources in the i18n locale map and introduced
de.jsontranslations. - Exposed German in the LanguageSelector UI and updated related unit tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vcrBuild.env.sh | Extends I18N_SUPPORTED_LANGUAGES to include de. |
| frontend/src/locales/index.ts | Registers de (and several de-* aliases) to load German resources. |
| frontend/src/locales/de.json | Adds German translations for the UI. |
| frontend/src/env.ts | Extends the Lang union + validated language list to include de. |
| frontend/src/components/LanguageSelector/LanguageSelector.tsx | Adds German to the language dropdown options. |
| frontend/src/components/LanguageSelector/LanguageSelector.spec.tsx | Updates tests to account for German support and adds a German display test. |
| "waitingRoom.precallNetworkTest.subtitle": "Testen Sie Ihren Gerätezugriff, Netzwerkkonnektivität und Anrufqualität, bevor Sie beitreten", | ||
| "waitingRoom.precallNetworkTest.stopTest": "Test stoppen", | ||
| "waitingRoom.precallNetworkTest.stoppedTitle": "Test gestoppt", | ||
| "waitingRoom.precallNetworkTest.stoppedMessage": "Sie haben den Netzwerktest gestoppt. Sie können es later erneut versuchen, wenn Sie bereit sind.", |
Comment on lines
+211
to
+212
| "zoom.out": "Zoom heransfahren", | ||
| "zoom.in": "Zoom hinausfahren", |
|
Contributor
|
QA reviewed LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Add German language support and translations
How should this be manually tested?
Check german exists.
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-632
Checklist
[X] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?