Skip to content

VIDSOL-580: fix vcr generate-keys command in README#398

Merged
Hossein-Movahed merged 2 commits intodevelopfrom
hossein/VIDSOL-580-readme-update
Mar 5, 2026
Merged

VIDSOL-580: fix vcr generate-keys command in README#398
Hossein-Movahed merged 2 commits intodevelopfrom
hossein/VIDSOL-580-readme-update

Conversation

@Hossein-Movahed
Copy link
Copy Markdown
Contributor

What is this PR doing?

Readme update

How should this be manually tested?

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-580

Checklist

[X] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

Copilot AI review requested due to automatic review settings March 4, 2026 15:52
@Hossein-Movahed Hossein-Movahed self-assigned this Mar 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the VCR deployment instructions in the root README to correct the vcr app generate-keys command so developers can generate application keys with the expected arguments.

Changes:

  • Fixes the vcr app generate-keys example to use <api-application-id> and include --region <region>.
  • Updates the accompanying explanation text to match the revised command.

@OscarFava
Copy link
Copy Markdown
Contributor

Why this change? I can see app-id being used.
Screenshot 2026-03-04 at 16 57 20

@Hossein-Movahed
Copy link
Copy Markdown
Contributor Author

Why this change? I can see app-id being used.

The <api-application-id> is just a placeholder for <app-id>, as mentioned in the ticket. If that’s confusing, I can switch it back to <app-id>.

@Hossein-Movahed Hossein-Movahed requested a review from VZaphod March 5, 2026 08:58
@VZaphod
Copy link
Copy Markdown
Contributor

VZaphod commented Mar 5, 2026

I think that either api-application-id or app-id are both ok. The root of this ticket cames from this slack thread https://vonage.slack.com/archives/C02TC4RNZ9Q/p1770895199204209 you can see that in the end Valdemar mentions .

@Hossein-Movahed
Copy link
Copy Markdown
Contributor Author

I will put app-id back to be less confusing 😄

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

@VZaphod VZaphod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hossein-Movahed Hossein-Movahed merged commit 0d8e312 into develop Mar 5, 2026
19 checks passed
@Hossein-Movahed Hossein-Movahed deleted the hossein/VIDSOL-580-readme-update branch March 5, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants