Skip to content

Cubic hermite splines#79

Open
dpugmire wants to merge 13 commits intoViskores:mainfrom
dpugmire:hermitesplines
Open

Cubic hermite splines#79
dpugmire wants to merge 13 commits intoViskores:mainfrom
dpugmire:hermitesplines

Conversation

@dpugmire
Copy link
Copy Markdown
Collaborator

@dpugmire dpugmire commented May 7, 2025

Create and evaluate cubic hermite interpolating splines.
These splines interpolate a set of given points. The parameter values for the interpolation can be user specified, or it will calculate a chord-length parameterization.

@dpugmire dpugmire requested a review from kmorel as a code owner May 7, 2025 18:26
@dpugmire
Copy link
Copy Markdown
Collaborator Author

dpugmire commented May 7, 2025

@kmorel does this look ok?

@dpugmire
Copy link
Copy Markdown
Collaborator Author

dpugmire commented May 8, 2025

@vicentebolea it looks like the cuda tests are failing. Are things ok on the testing side?

@kmorel
Copy link
Copy Markdown
Collaborator

kmorel commented May 8, 2025

@vicentebolea I have been seeing the Cuda dashboards fail a lot recently from what looks like an inability to use the device. Sometimes it works, sometimes it does not.

It might be that one of the runners, athena-nvidia-a100-0, is not working correctly. When I look at other PRs with a different runner, voltar-nvidia-a100-0, it seems to work correctly. Who do we contact if there seems to be something wrong with the runners?

Here are some examples of jobs:

@kmorel kmorel self-requested a review May 8, 2025 14:44
Copy link
Copy Markdown
Collaborator

@kmorel kmorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should also really have a changelog added to it.

@vicentebolea
Copy link
Copy Markdown
Collaborator

@vicentebolea I have been seeing the Cuda dashboards fail a lot recently from what looks like an inability to use the device. Sometimes it works, sometimes it does not.

It might be that one of the runners, athena-nvidia-a100-0, is not working correctly. When I look at other PRs with a different runner, voltar-nvidia-a100-0, it seems to work correctly. Who do we contact if there seems to be something wrong with the runners?

Here are some examples of jobs:

* athena (bad): https://gitlab.spack.io/viskores/viskores/-/jobs/16506643

* voltar (good): https://gitlab.spack.io/viskores/viskores/-/jobs/16505183

@kmorel we can pin down the job to one of these runners for the time being. As for who to contact it would be Luke from UO (or Sameer). Email or the HPSF slack is how I have been communicating with them outside of the HPSF CI meetings

Copy link
Copy Markdown
Collaborator

@kmorel kmorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windows build is still being picky about data type conversion. There are a few more fixes left.

@kmorel kmorel self-requested a review May 12, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants