Draft
Conversation
Viskores no longer makes the device libraries public on its exported `viskores::cont` target. Previously, the device libraries were linked to `viskores::cont` as `PUBLIC`, which means that pretty much anything that used Viskores also brought in any compiler flags for the device. This sometimes forced downstream code to use a device compiler when it did not need to.
The virtual methods that initialized Kokkos were implemented in a header file. That could cause them to be defined in multiple translation units and libraries, which could then cause issues with global variables. The methods are moved to a .cxx file that is wrapped into a library.
Before checking whether to print the usage statement and exiting, initialize the device subsystems. I have seen an issue where if you do not initialize them, you can get a crash on exit.
kmorel
force-pushed
the
kokkos-shared-wip
branch
from
9f17c6b to
b1be482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.