[android] remove MIMETYPE_TEXT_PLAIN check#13
Open
jonmaim wants to merge 1 commit intoVersoSolutions:masterfrom
Open
[android] remove MIMETYPE_TEXT_PLAIN check#13jonmaim wants to merge 1 commit intoVersoSolutions:masterfrom
jonmaim wants to merge 1 commit intoVersoSolutions:masterfrom
Conversation
This is more like a question instead of a PR. Can we safely remove this check? Indeed, it makes copy/pasting from HTML emails to work.
|
I just did this myself to fix the same issue. However, I think we should make a call to coerceToText() instead of getText() although it does work with just toString(). |
|
Hi! I don't know what those lines do but maybe they could be removed... Because it crashes on (Note: I'm not a Java/Android developer so I don't know if they are necessary....) logcat: I've found this issue testing through the Amazon Device farm... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more like a question instead of a PR.
Can we safely remove this check?
Indeed, it makes copy/pasting from HTML emails to work.