feat: rbrKnowledgeSoundness of BinaryBasefold & ring-switching#296
feat: rbrKnowledgeSoundness of BinaryBasefold & ring-switching#296chung-thai-nguyen wants to merge 1 commit intobinarybasefold-proofsfrom
Conversation
🤖 Gemini PR SummaryThis PR formalizes the Round-by-Round (RBR) knowledge soundness for major components of the Binius proof system, specifically the Binary Basefold and Ring-Switching protocols. It establishes the necessary probability bounds, extraction logic, and simulation infrastructure required for a complete formal security proof in Lean. Features
Fixes
Refactoring
DocumentationNo explicit documentation files were modified, but the PR includes significant formalization of protocol specifications and lemmas which serve as the primary technical documentation for the proof system's security properties. Analysis of Changes
✅ **Removed:** 9 `sorry`(s)
❌ **Added:** 19 `sorry`(s)
🎨 **Style Guide Adherence**This review is based on the provided ArkLib Style Guide. Several lines violate naming conventions, formatting rules, and documentation standards. Naming Convention Violations
Syntax and Formatting Violations
Documentation and Header Violations
📄 **Per-File Summaries**
Last updated: 2026-02-12 17:05 UTC. |
f911ee6 to
ccfb501
Compare
f84047a to
16bbca7
Compare
7654f36 to
1631470
Compare
|
FYI I'll merge the 4.26 PR first, so keep an eye out for any proofs breaking when that happens. |
|
@alexanderlhicks Sure I will take a look. |
26a1095 to
c57ce1a
Compare
405bb09 to
2098d79
Compare
2098d79 to
56eb214
Compare
No description provided.