[VPD-1314] Configure PrimeV2 on BSC#712
Open
Debugger022 wants to merge 2 commits into
Open
Conversation
Bring PrimeV2 + PrimeLeaderboard live on bsctestnet: accept ownership, grant ACM perms (epoch ops to NormalTimelock + Guardian), wire the pair, repoint PrimeLiquidityProvider, add Core pool markets, open the mint window, and pause the legacy Prime. Includes fork simulation.
GitGuru7
reviewed
Jun 1, 2026
| const ALL_TIMELOCKS = [NORMAL_TIMELOCK, FAST_TRACK_TIMELOCK, CRITICAL_TIMELOCK]; | ||
|
|
||
| // Grant a single ACM permission for `target.signature` to every timelock in `accounts`. | ||
| const grant = (target: string, signature: string, accounts: string[] = [NORMAL_TIMELOCK]) => |
Contributor
There was a problem hiding this comment.
The comment mentions "for every timelock," but the permission is actually assigned only to NT.
| }); | ||
|
|
||
| it("Guardian can call issue / burn / setMintThreshold on PrimeV2", async () => { | ||
| for (const sig of ["issue(address)", "burn(address)", "setMintThreshold(uint256,uint256)"]) { |
Contributor
There was a problem hiding this comment.
missing assertions for
"issueBatch(address[])"
"burnBatch(address[])"
can also add the event check for the ACM commands
| }); | ||
|
|
||
| it("Guardian can seed stakers on PrimeLeaderboard", async () => { | ||
| for (const sig of ["initializeStakers(address[],uint256[],uint64[])", "finalizeInitialization()"]) { |
Contributor
There was a problem hiding this comment.
missing for
setMultiplierTiers(uint256[],uint256[])
setPrimeV2(address)
setMaxLoopsLimit(uint256)
Contributor
|
missing command for |
Contributor
|
also update the Prime address in the Comptroller ? |
Add missing XVSVault.setPrimeToken (-> PrimeLeaderboard) and Comptroller.setPrimeToken (-> PrimeV2); extend sim assertions and fix grant helper comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
VIP (
vips/vip-675/bsctestnet.ts)setPrimeToken).setMintThreshold(1 XVS effective stake, no deadline).togglePause()(note:setLimit(0,0)revertsInvalidLimit— tokens already minted).Simulation (
simulations/vip-675/bsctestnet.ts)Test plan
npx hardhat test simulations/vip-675/bsctestnet.ts --fork bsctestnet→ 62 passing (verified at block 110244560).yarn tsc --noEmit,npx eslint,npx prettier --checkon both files → clean.