Postgres primary key - #3230
Merged
Merged
Conversation
davidraker
requested review from
Copilot and
schandrika
and removed request for
Copilot
July 7, 2026 00:44
schandrika
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a key change to the database schema setup in the
setup_historian_tablesfunction, specifically for the data table inpostgresqlfuncts.py. The main update is to enforce a composite primary key on the(topic_id, ts)columns, replacing the previous unique constraint, and to remove a redundant index creation when using TimescaleDB.Database schema improvements:
(topic_id, ts)instead of a unique constraint, ensuring stronger data integrity and potentially improving query performance.(topic_id, ts)when using TimescaleDB, as the primary key already provides the necessary indexing.# DescriptionPlease include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: