Skip to content

chore: Simplify db+k8s example#126

Open
s-h-a-d-o-w wants to merge 1 commit intoUpCloudLtd:mainfrom
s-h-a-d-o-w:simplify-db-k8s-example
Open

chore: Simplify db+k8s example#126
s-h-a-d-o-w wants to merge 1 commit intoUpCloudLtd:mainfrom
s-h-a-d-o-w:simplify-db-k8s-example

Conversation

@s-h-a-d-o-w
Copy link
Copy Markdown

@s-h-a-d-o-w s-h-a-d-o-w commented Mar 6, 2026

This is more of a "demo PR".
Because as I was experimenting with this example, I refactored it. But a lot of this is up to taste, so I don't know how much you'd be interested in merging.
One thing that seems to be an objective improvement though (reliability and type safety) is the use of getKubernetesClusterOutput.

Why I changed other things that are more subjective:

  • Using a function instead of a class (for app deployment) for easier maintainability. Almost nothing was shared across the class and it wasn't instantiated multiple times.
  • Use of ESM - allows for top-level await and IMO best practice these days.

One thing that I recognize as awkward is namespaceName: namespace, but I couldn't think of anything better that avoids shadowing inside of createFeedbackApp.

If you only want to merge part of it, just let me know what I should revert.

@s-h-a-d-o-w s-h-a-d-o-w requested a review from a team as a code owner March 6, 2026 12:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant