Skip to content

chore(learn): clean page footer#428

Merged
leowla merged 2 commits into
masterfrom
chore/learn-page-footer
Jun 26, 2026
Merged

chore(learn): clean page footer#428
leowla merged 2 commits into
masterfrom
chore/learn-page-footer

Conversation

@leowla

@leowla leowla commented Jun 23, 2026

Copy link
Copy Markdown
Member

Issue

New users will not be editing the docs or making a new 11ty website.

Solution

Remove the irrelevant buttons and links leftover from template.

Risk

None

Checklist

  • Acceptance criteria met
  • Wiki documentation is written and up to date

Summary by CodeRabbit

  • Changes

    • Simplified page footer design for improved clarity
  • Documentation

    • Added New User Guide link to the Useful Links section

leowla added 2 commits June 23, 2026 20:15
Remove `editThisPage` button and link to 11ty template
@leowla leowla requested a review from harbassan June 23, 2026 08:23
@leowla leowla self-assigned this Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f28d97d4-0628-41c6-a198-4ff789309985

📥 Commits

Reviewing files that changed from the base of the PR and between 137006e and 4ad4e80.

📒 Files selected for processing (3)
  • learn/_includes/libdoc_page.liquid
  • learn/settings.json
  • wiki/VPS Home.md
💤 Files with no reviewable changes (1)
  • learn/settings.json

📝 Walkthrough

Walkthrough

The learn site's page footer is simplified to an empty padded element, removing the edit-this-page link, dashed divider, and version row. The editThisPageRootUrl field is removed from learn/settings.json. Separately, a "New User Guide" link is added to the wiki home page's Useful Links section.

Changes

Learn site footer cleanup and wiki update

Layer / File(s) Summary
Remove edit-this-page footer and config
learn/settings.json, learn/_includes/libdoc_page.liquid
editThisPageRootUrl is deleted from the JSON config, and the full footer markup (spacer divider, edit link, GitHub/11ty version row) is replaced with <footer class="pt-11"></footer>.
Add New User Guide wiki link
wiki/VPS Home.md
A new "New User Guide" bullet is inserted under the Useful Links section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A footer once cluttered with links and with text,
Now rests as a whisper — what comes next?
The edit-this-page has hopped away clean,
A wiki link sprouts where a guide should be seen.
🐇 Less is more, says the rabbit in green!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore(learn): clean page footer' accurately describes the main change: removing irrelevant footer elements from the learn page template.
Description check ✅ Passed The description covers all main sections including Issue, Solution, and Risk, though two checklist items were left unchecked (unit and integration tests). The description adequately explains why footer elements were removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/learn-page-footer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harbassan harbassan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto

@leowla leowla merged commit 6679b3e into master Jun 26, 2026
3 checks passed
@leowla leowla deleted the chore/learn-page-footer branch June 26, 2026 09:48
GogaIV pushed a commit that referenced this pull request Jul 7, 2026
Remove irrelevant buttons and links leftover from template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants