Skip to content

Vps 31/number input objects#417

Draft
GogaIV wants to merge 13 commits into
masterfrom
VPS-31/number-input-objects
Draft

Vps 31/number input objects#417
GogaIV wants to merge 13 commits into
masterfrom
VPS-31/number-input-objects

Conversation

@GogaIV

@GogaIV GogaIV commented May 26, 2026

Copy link
Copy Markdown
Contributor

Issue

Need num input for x y width and height for canvas objects

Solution

Use the same method as when resizing objects with the mouse, add num input for x y and then calc width based on both x and height based on both y's

Vid

vps-2026-05-30_17.34.28.mp4

Risk

none isolated component

Other

There is check if num else reject but its just a popup below the input box idk if there is another way preferable that is common throughout the site for errors.

Checklist

  • Acceptance criteria met
  • Wiki documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous integration build passing

@linear

linear Bot commented May 26, 2026

Copy link
Copy Markdown

VPS-31

GogaIV added 5 commits May 29, 2026 20:09
: update val if shape is dragged etc/updated outside func + introduce rejection for non num
@GogaIV GogaIV requested review from harbassan and hazikchaudhry May 30, 2026 05:23
@GogaIV GogaIV marked this pull request as ready for review May 30, 2026 05:24
@GogaIV GogaIV requested a review from leowla May 30, 2026 05:24
@br-Chan

br-Chan commented May 30, 2026

Copy link
Copy Markdown
Contributor

In regards to input validation, could we instead prevent non-number inputs in each field rather than allowing the user to type characters?

@GogaIV

GogaIV commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

In regards to input validation, could we instead prevent non-number inputs in each field rather than allowing the user to type characters?

yeah that was an option between like 3 other options I had

vps-2026-05-30_20.07.25.mp4

i was inputting letters it was jst rejecting

looked like this, it was okay but i couldn't decide so i just copied google slides implementation it jst tells if you input something incorrectly

I can do either idm one just saves val prior to checking if its a num other checks first then saves

@leowla leowla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work for line and speech box. Is this intentional?

Comment thread frontend/package.json Outdated
Co-authored-by: Leo Wang <git@leowla.com>
@GogaIV

GogaIV commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

Does not work for line and speech box. Is this intentional?

No I didn't test it but I also assumed it would cuz it should all be component objects, let me look into it

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b32e368-9bca-4507-a86b-2756415d33a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch VPS-31/number-input-objects

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GogaIV GogaIV force-pushed the VPS-31/number-input-objects branch from 027353e to d20d899 Compare July 7, 2026 07:12
@GogaIV GogaIV marked this pull request as draft July 7, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants